search

nostrbuild / nostr.build

FOSS version of nostr.build
https://nostr.build
MIT License
58 stars 10 forks source link

remove legacy API #69

Closed fishcakeday closed 4 months ago

fishcakeday commented 4 months ago

It has been a year since a new API was deployed, it is time to move on and deprecate the legacy code.

mplorentz commented 4 months ago

Oh hey, we were using this in production and didn't realize it was going away. We can update to the new version, but any chance you can turn the legacy API back on for a couple weeks until we can get a new release out the door?

fishcakeday commented 4 months ago

Oh hey, we were using this in production and didn't realize it was going away. We can update to the new version, but any chance you can turn the legacy API back on for a couple weeks until we can get a new release out the door?

Which path did you use, I can put it back for a couple of weeks, yes.

fishcakeday commented 4 months ago

Oh hey, we were using this in production and didn't realize it was going away. We can update to the new version, but any chance you can turn the legacy API back on for a couple weeks until we can get a new release out the door?

Which path did you use, I can put it back for a couple of weeks, yes.

Ok, I saw you needed ios.php, so I reverted that one only. Let me know when you are done implementing authenticated upload either using nip96 (with nip98) or using the new API.

mplorentz commented 4 months ago

🙏 thank you very much. Will do.

mplorentz commented 4 months ago

@fishcakeday we are done with our implementation. It has been released and has good adoption. Thanks again for the grace time.

fishcakeday commented 3 months ago

@fishcakeday we are done with our implementation. It has been released and has good adoption. Thanks again for the grace time.

Thank you! I will keep it there for another month to ensure that we get maximum adoption. Also, please make sure that you are sending nip98 headers, since I also have #70 pending merge soon.

mplorentz commented 3 months ago

@fishcakeday oh dear. We aren't sending NIP-98 headers yet. We can add them ASAP and do another release. But are you requiring them starting today?

Is there somewhere I can get notified of breaking changes to your API without watching the whole github repo?

fishcakeday commented 3 months ago

I’ll delay the release, please do not worry. I’ll push it by a month so you have all the time you need, or longer if required.