search

nostrbuild / nostr.build

FOSS version of nostr.build
https://nostr.build
MIT License
58 stars 10 forks source link

Server URL in "ox" tag in NIP-96 Upload Response #73

Closed Ademan closed 2 months ago

Ademan commented 2 months ago

The response for a successful NIP-96 upload includes a NIP-94 event including the "ox" tag.

In addition to the SHA256 original file hash, nostr.build includes the base URL of the server. This is causing nostr-tools to choke on the response.

Arguably, nostr-tools is performing excessive validation, but including the URL does appear to be out of spec.

I don't entirely understand the purpose of including it there, so I'm starting here, to try to understand exactly what's going on.

fishcakeday commented 2 months ago

Fixed and deployed, thanks for pointing it out.