search

nostrver-se / nostr-php

PHP helper library for Nostr https://nostr-php.dev
https://nostr-php.dev
MIT License
50 stars 15 forks source link

Change utf8_encode because is deprecated #25

Closed quentintaranpino closed 1 year ago

pjv commented 1 year ago

OK, so the primary reason that utf8_encode has been deprecated in php 8.2 is that it made the assumption that the encoding of the string it was working on was ISO-8859-1 and it blindly converted whatever it was fed from ISO-8859-1 to utf8.

So this PR does exactly the same thing: it assumes the input is encoded as ISO-8859-1 and converts to utf8. But since iconv is not deprecated it will clean up the deprecation notices.

But what if the input is not ISO-8859-1?

I don’t know what the right answer is; there is prior art for detecting current encoding here: https://github.com/BYVoid/uchardet, but that’s not a PHP library and it seems like guessing encoding is a hard problem with a lot of fiddly edge cases.

My use-case for nostr-php already has all input encoded as utf8. I’m wondering if maybe that will be true for vastly more users than not and maybe (even though NIP-01 specifies utf8) in practice the better thing would be to either just not mess with the encoding at all (i.e. $id = hash('sha256', $hash_content);) or make the input encoding configurable by the user and have that be a parameter to iconv.

quentintaranpino commented 1 year ago

OK, in fact we only remove the warning with the change. I agree with your proposal 😀