search

nostrver-se / nostr-php

PHP helper library for Nostr https://nostr-php.dev
https://nostr-php.dev
MIT License
50 stars 15 forks source link

It seems that it's not needed to close the connection in the function `send()` #28

Closed georgkaser closed 10 months ago

georgkaser commented 1 year ago 
          It seems that it's not needed to close the connection in the function `send()`: After commenting `$client->close();` it works fine with no exception. Is the connection closing automatically?

Originally posted by @georgkaser in https://github.com/swentel/nostr-php/issues/26#issuecomment-1498684799

swentel commented 1 year ago

Hmm, weird, I've not encountered that issue yet when testing myself.

We'll have to read up on the client library.

(note: I'm on holiday until the 17th, so a bit slow at the moment)

georgkaser commented 1 year ago

No problem, have a nice holiday. I will try to implement your classes into an REDAXO CMS Addon. Will also need time, because I will do it in my free time. I will keep you updated :)

Sebastix commented 10 months ago

Fixed in https://github.com/swentel/nostr-php/pull/46