search

nostrver-se / nostr-php

PHP helper library for Nostr https://nostr-php.dev
https://nostr-php.dev
MIT License
50 stars 15 forks source link

fixing some response typos and stricter comparisons of relay responses #34

Closed Sebastix closed 11 months ago

pjv commented 12 months ago

@Sebastix I don’t remember without doing some testing what the response object looks like, but did you mean to invert the logic in the test of the contents of response[2] in line 38?

It looks to me like the original intent of line 38 was to test if response[2] was an implicit TRUE, your commit changes the test to whether it’s an explicit FALSE. Is that on purpose?

Sebastix commented 12 months ago

@pjv Me stupid, it should be TRUE indeed. I think it was too late while I was working on this. I committed the fix! Thanks for your alert!