search

nostrver-se / nostr-php

PHP helper library for Nostr https://nostr-php.dev
https://nostr-php.dev
MIT License
53 stars 15 forks source link

Add key generation methods using elliptic-php #8

Closed eko2one closed 1 year ago

eko2one commented 1 year ago

@swentel How can we add tests for this? Do you think we need validation for type hex and bit length?

swentel commented 1 year ago

I see there are tests in https://github.com/simplito/elliptic-php/blob/master/tests/ECDHTest.php - so I think we're fine to be honest.

eko2one commented 1 year ago

Well, just added a test for getPublicKey.

swentel commented 1 year ago

Oh nice! I think that looks good. Unless you've got anything else, I'll merge in a couple of minutes.

eko2one commented 1 year ago

LFG

swentel commented 1 year ago

I assume that's a yes? Not familiar with that one :)

eko2one commented 1 year ago

Yes :)

swentel commented 1 year ago

Alright, done, thanks!