nosuchtim
commented
1 year ago Cool, I’m new to this process as well, so we’ll both be learning!
…Tim…On Thu, Mar 23, 2023 at 9:24 AM pbarada @.***> wrote:
Tim, Being the first time I've collaborated on github, I hope I created this pull request correctly by using git-format-patch to generate patches of my changes from my repo and used git-am to merge them into this branch in your repo and from that this pull request...
Hopefully it looks good...
You can view, comment on, or merge this pull request online at:
https://github.com/nosuchtim/keykit/pull/12 Commit Summary
- 08e0880 https://github.com/nosuchtim/keykit/pull/12/commits/08e0880aef0f562745ba7f9b426cd13b4a145357 Fix build failures on Ubuntu 22.04LTS
- f2c641e https://github.com/nosuchtim/keykit/pull/12/commits/f2c641e85af7a005d5f20fa6114679f63a71d6d8 Ignore generated/copies files
- 5343b7d https://github.com/nosuchtim/keykit/pull/12/commits/5343b7d398e30afabeb4bf0eeef516b54fd2d87a Increase compiler warning level
- 65f8c03 https://github.com/nosuchtim/keykit/pull/12/commits/65f8c03ca88a816a5033ebe0456108250e00c962 Reduce unused parameter warnings
- 4f658b8 https://github.com/nosuchtim/keykit/pull/12/commits/4f658b8b758eacfb9265dbf754b14963a8b4a0af Reduce empty else warnings
- 139949b https://github.com/nosuchtim/keykit/pull/12/commits/139949bc08fefb6dce52b382e9d6af062650694d Reduce maybe-unitialized warnings
- 9c3aecb https://github.com/nosuchtim/keykit/pull/12/commits/9c3aecbe25779e048793604b15a5443adc7950e3 Create rule to generate d_xx.h prototype headers from d_xx.c source
- 0ef5cdf https://github.com/nosuchtim/keykit/pull/12/commits/0ef5cdfd113fa2743a4f15abaf592cb5a617369a Change __attribute usage
- cd5d1d8 https://github.com/nosuchtim/keykit/pull/12/commits/cd5d1d8127e37d87e62fbf1ee9b6935c12800fd8 Fix format mismatch warning from passing fd_set to sprintf
- e340041 https://github.com/nosuchtim/keykit/pull/12/commits/e340041cd6e3cbeae14044cc22b7f48cb5511b14 Only replace file if content changes
- d694d6e https://github.com/nosuchtim/keykit/pull/12/commits/d694d6e0880852d8972f260c4d2e5b5b8f724eaa Reduce format mismatch warnings
- 40e991a https://github.com/nosuchtim/keykit/pull/12/commits/40e991a1bfc331db04697c981cec004350b3805f Fix missing braces around initializer warnings
- be6d2c5 https://github.com/nosuchtim/keykit/pull/12/commits/be6d2c5cf490e2438651d559f6fa86216cec3d21 Recude value computed not used warnings
- 8059c37 https://github.com/nosuchtim/keykit/pull/12/commits/8059c3790adf7a152d4ba846f7b60a78c66ea4e5 Removed unused variables
- 0757cb1 https://github.com/nosuchtim/keykit/pull/12/commits/0757cb161e3b110e66d7d29fa686894e085c46d7 Fix set but not used warnings
- c20c547 https://github.com/nosuchtim/keykit/pull/12/commits/c20c547fbc903efd81cde766d63a7a6c588af1d2 Fix sign compare warnings
- 64b5bda https://github.com/nosuchtim/keykit/pull/12/commits/64b5bda31f746de7f14bd269b871b9e410ac5b8e Fix nested comment warnings
- bc40483 https://github.com/nosuchtim/keykit/pull/12/commits/bc404832093029e6fb9bd8baf70b1798fff095ed Cast return from kmalloc to expected type
- 661caec https://github.com/nosuchtim/keykit/pull/12/commits/661caec90c3125bf5ce6439878311708f28e3f8f Reduce maybe uninitialized warnings
- b7ec29a https://github.com/nosuchtim/keykit/pull/12/commits/b7ec29a936511735113f95d2fb080af6eec41e60 Reduce pointer-sign warnings
- 217318c https://github.com/nosuchtim/keykit/pull/12/commits/217318cb8de0179d425b837fad977d4af47aadd3 Fix stringop truncation warning
- ac8349a https://github.com/nosuchtim/keykit/pull/12/commits/ac8349af5aa785b6816056e72afdd5ff00b00fad Fix char array subscript warnings
- b228c65 https://github.com/nosuchtim/keykit/pull/12/commits/b228c65fdec9e468d0c3c926a769d5bba95424fb Eliminate fallthrough warning
- 4a4c3cc https://github.com/nosuchtim/keykit/pull/12/commits/4a4c3cc907828bfca01ebf66e2ba38aabdd0ea93 Removed unreferenced static functions
File Changes
(30 files https://github.com/nosuchtim/keykit/pull/12/files)
- M .gitignore https://github.com/nosuchtim/keykit/pull/12/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947 (15)
- M mdep/linux/makefile https://github.com/nosuchtim/keykit/pull/12/files#diff-a5eff5755e7181a48ea19f500e5c2e0d38415f44aeb32ffdd79f6c208ab595ff (67)
- M mdep/linux/mdep.h https://github.com/nosuchtim/keykit/pull/12/files#diff-af600d61d9d08b4bc285f89e2292dea1dc7e7a0471b2778f23158540b34c72ac (4)
- M mdep/linux/mdep1.c https://github.com/nosuchtim/keykit/pull/12/files#diff-a841b9209f1bb9648597b0e309bc4e9cd98bce5cb97fa5676822c7b05bcecb77 (4)
- M mdep/linux/mdep2.c https://github.com/nosuchtim/keykit/pull/12/files#diff-ef0ae70676e5b80688da9228bd63a2038ef7f20aebcc6cd559713232bb613fc1 (95)
- M mdep/linux/midi.c https://github.com/nosuchtim/keykit/pull/12/files#diff-6dee668be75feae4686d38872867ccca06e3d5ddb502b8d8a73932475aaea503 (42)
- M mdep/stdio/makefile https://github.com/nosuchtim/keykit/pull/12/files#diff-5a4bc5aa1c2f1675cb630ddcb8b47635f6d0373ab9e197c6e216a0923857e787 (4)
- M mdep/stdio/mdep.h https://github.com/nosuchtim/keykit/pull/12/files#diff-b5a2d4cd4b80d8cd5d8846bcc11b786b117b50f6f9301d387e26b89d7d82dc9a (3)
- M mdep/stdio/mdep1.c https://github.com/nosuchtim/keykit/pull/12/files#diff-16757a5d8c5a617665db3ed056414e4e02315b512c05c591d982c7d3e41df7c1 (4)
- M mdep/stdio/mdep2.c https://github.com/nosuchtim/keykit/pull/12/files#diff-7a05099a883d1f7a062942280dbbef455fdac08fdd3ec745bc9cee25d19e8288 (101)
- M mdep/stdio/midi.c https://github.com/nosuchtim/keykit/pull/12/files#diff-76c6ffe26ff3475ba40f093f0b89be153d541e055303ff9a6b88cb9a7c44eb96 (9)
- M mdep/stdio/rmcr https://github.com/nosuchtim/keykit/pull/12/files#diff-8705f941af36036fd8d441387061720f0c8673769a1be83988023d95df7738a6 (2)
- M src/bltin.c https://github.com/nosuchtim/keykit/pull/12/files#diff-afaf4c368cec35346aaf566f70514c8ed5f70dc0beb30e74e9181defdcb04737 (205)
- M src/code.c https://github.com/nosuchtim/keykit/pull/12/files#diff-5e1dfefcfd94cf2d24f7cef972500fd6ed88afaae360200d3ab91ea898ce8a8d (18)
- M src/code2.c https://github.com/nosuchtim/keykit/pull/12/files#diff-3504c78526fa3d94b2c9858188ed46e9b67824a49301b9bc2708d030daa53c6d (6)
- M src/grid.c https://github.com/nosuchtim/keykit/pull/12/files#diff-cd9f850ec7d3bc1e58dc9187ad4575da4b6595117e979ab174408b4c7342f2d2 (16)
- M src/key.h https://github.com/nosuchtim/keykit/pull/12/files#diff-6c397f7958e890c05ec03255d9e65943bd8a86e8da39f287ab0ecc2bf6a4bc72 (29)
- M src/keyto.c https://github.com/nosuchtim/keykit/pull/12/files#diff-607ed45254a5e5fd36953223454c4e5ea1ebe2ba008de845f50a7f2ae17ac28f (32)
- M src/kwind.c https://github.com/nosuchtim/keykit/pull/12/files#diff-995a8c9083bd52a4314521cb95fbf3fa7e62165fd4690a8f8fb7154a8a7a1e2d (14)
- M src/main.c https://github.com/nosuchtim/keykit/pull/12/files#diff-e0cf5b28d9b6b600f0af2bc78e8fd30ec675fd731a5da86f0c4283ffc0e40176 (8)
- M src/meth.c https://github.com/nosuchtim/keykit/pull/12/files#diff-8798dd47e465b43a6eed9619066acf8d926c7e6f583652a25e1bac3d1cb55f77 (29)
- M src/mfin.c https://github.com/nosuchtim/keykit/pull/12/files#diff-0e088ef47e01c14ae818d7b7abbfca812b5d52486a9ab909691005b4806de29b (3)
- M src/misc.c https://github.com/nosuchtim/keykit/pull/12/files#diff-9df9e2c313e694cf242534e90c1187fe119fac8de7c304ae438de0736209953b (3)
- M src/phrase.c https://github.com/nosuchtim/keykit/pull/12/files#diff-cb33c622a064b5320899a7d2245d6252ee32820b5d96e41d4e03956e702ae903 (2)
- M src/protoflp.c https://github.com/nosuchtim/keykit/pull/12/files#diff-d1e09c4779e6f940092e6360c22946c504ba380d9c4cc82ebacd5ac7c0c99676 (16)
- M src/real.c https://github.com/nosuchtim/keykit/pull/12/files#diff-a3f1004559c05bcde34a2505ea84a476b439641eebd0d52a61654d9020b5135f (5)
- M src/regex.c https://github.com/nosuchtim/keykit/pull/12/files#diff-dbb70867a6cb743cbc9b8bb1e9685c340e98cf620ba5dc981f6c593ae992a853 (7)
- M src/sym.c https://github.com/nosuchtim/keykit/pull/12/files#diff-4df47ce518492087171e3f3d918795ace3a59a538dfd665e7f5cebcc64900d0d (361)
- M src/task.c https://github.com/nosuchtim/keykit/pull/12/files#diff-1ac89047bd5ddf49f271321da0d86793efdc534d0edd56548b3ea0dcd2f37c04 (189)
- M src/util.c https://github.com/nosuchtim/keykit/pull/12/files#diff-40aa21688f1ac58ddf8ef5f0f4e472e6075411f5c4f75b9c1d512b7e03a2cbab (18)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/nosuchtim/keykit/pull/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABESNXPQDPTYSWDN2CCUI3W5R2M3ANCNFSM6AAAAAAWFN5UGA . You are receiving this because your review was requested.Message ID: @.***>
Tim, Being the first time I've collaborated on github, I hope I created this pull request correctly by using git-format-patch to generate patches of my changes from my repo and used git-am to merge them into this branch in your repo and from that this pull request...
Hopefully it looks good...