search

not-an-aardvark / snoowrap

A JavaScript wrapper for the reddit API
MIT License
1.01k stars 125 forks source link

Correct captcha var/type for composeMessage? #335

Open OmgImAlexis opened 3 years ago

OmgImAlexis commented 3 years ago

Is this meant to be using captchaResponse or captcha for the argument? The jsdocs and the code seem to disagree with each other.

https://github.com/not-an-aardvark/snoowrap/blob/fdf5c2af0443cfc3e6ee544445aaa46e602d4f1b/src/snoowrap.js#L1312-L1340

OmgImAlexis commented 3 years ago

@SpyTec could I get some guidance here?

Venefilyn commented 3 years ago

@OmgImAlexis it seems like the correct usage should be captcha. So the JSDoc and TS definitions are both wrong. I noticed that submit utilizes captchaResponse instead. But this might also be something for the v2.0 breaking change #300