Closed jehendeoff closed 1 year ago
Currently not at home, I'll keep an eye on my mails. Feel free to ping me when you're read for a review :) Thank you for contributing!
Hi @not-jan, I think I finished implementing the gif renderer and provider, I'd like if you could take a look at the code and tell me if anything seems wrong
Hey, I'm getting the following compilation error when I try to build: E0635 I'm not that into rust so I can't really help you out there but it says "The #![feature] attribute specified an unknown feature."
Hi @Socerest2, that's weird, I could compile it yesterday, could you tell me what's your OS, your rust version, and the full output of the fail? and, does it also fails with the main branch? (if so, it seems a feature was removed from rust nightly)
Hey, I'm getting the following compilation error when I try to build: E0635 I'm not that into rust so I can't really help you out there but it says "The #![feature] attribute specified an unknown feature."
do you still have your issue ? I managed to compile it just today, so I think you have a problem on your end, and I think your issue should also be present when compiling the main branch? correct me if I'm wrong please
Hey Sorry! I have a bad habit of not checking github sometimes! I still have the error.
I think I did everything that you asked for, if you see anything new that's wrong, please tell me, I'll gladly fix it
Merged, thank you so much! :)
Hi, I tried to implement gifs as both : a provider and a renderer, so that it could potentially easily integrated in other providers.
If you see anything that I should change, please don't hesitate, I'm still a beginner in rust.
Please note before approving that this is an experiment, and in no way should it be the last version to hit production.