not-jan / apex-tux

Linux support for the OLED screen of the Apex Pro, Apex 5 and Apex 7 keyboards by SteelSeries
The Unlicense
73 stars 15 forks source link

Automatically change provider #45

Closed jehendeoff closed 1 year ago

jehendeoff commented 1 year ago

This PR should change the provider every X seconds (customizable in settings.toml, by default it's 30 seconds if no settings are found) this features is also disable-able (by settings 0 second in settings.toml)

This PR is made to aid #5

SalahAdDin commented 1 year ago

It is the media player provider, right? would not it be better to automatically detect which media player is being used now? is it hard?

jehendeoff commented 1 year ago

no it's not, it's made to change between every provider (music, sysinfo, clock, coindesk, image etc.), if it did, it wouldn't help with screen burn-in

not-jan commented 1 year ago

no it's not, it's made to change between every provider (music, sysinfo, clock, coindesk, image etc.), if it did, it wouldn't help with screen burn-in

Coming to think of it. We should probably make some sort of IPC interface to change the current provider.

jehendeoff commented 1 year ago

Coming to think of it. We should probably make some sort of IPC interface to change the current provider.

While I do agree with you, I also think that we should make an interface (maybe a similar one to the steelseries one (to "replace" it)) to control the actual pixel.

(moreover, while I would like to help you with making an IPC interface I don't know how they work, so I can't help you for now)

not-jan commented 1 year ago

Coming to think of it. We should probably make some sort of IPC interface to change the current provider.

While I do agree with you, I also think that we should make an interface (maybe a similar one to the steelseries one (to "replace" it)) to control the actual pixel.

(moreover, while I would like to help you with making an IPC interface I don't know how they work, so I can't help you for now)

I'll try and design something soon if I do find the time :)

not-jan commented 1 year ago

Is this ready to be reviewed?

jehendeoff commented 1 year ago

I think it is, it should work everywhere

not-jan commented 1 year ago

Thanks! :)