search

not-kennethreitz / flask-sslify

Force SSL on your Flask app.
https://pypi.python.org/pypi/Flask-SSLify
BSD 2-Clause "Simplified" License
504 stars 85 forks source link

Add option to SSLify when debug is enabled, too. #46

Closed rosensama closed 5 years ago

josegonzalez commented 8 years ago

👍

stevewilhelm commented 7 years ago

FYI. documentation calls the option debug_ssl, code defines it as ssl_debug.

Projjol-zz commented 5 years ago

@rosensama if you can update the PR by resolving existing conflicts I'll be happy to check and merge 👍

rosensama commented 5 years ago

Looks like that should be easy enough, but the README says it's no longer maintained, so how does the PR help?

On Sat, Feb 16, 2019 at 1:12 AM Projjol Banerji notifications@github.com wrote:

@rosensama https://github.com/rosensama if you can update the PR by resolving existing conflicts I'll be happy to check and merge 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kennethreitz/flask-sslify/pull/46#issuecomment-464299084, or mute the thread https://github.com/notifications/unsubscribe-auth/ACNwSLuBkIvttiHfgynJSNd3MyEonzclks5vN6E8gaJpZM4Jo8n2 .

timofurrer commented 5 years ago

@rosensama are you still using flask-sslify? Can you switch to https://github.com/GoogleCloudPlatform/flask-talisman ?

rosensama commented 5 years ago

@timofurrer correct, I no longer use flask-sslify. Was just responding to @Projjol's request.

timofurrer commented 5 years ago

Yeah, that's absolutely, fine. I was just curious. So, I think I'm going to close this PR (even though it's fully legit ;)) and see if I can archive this repository.

Thanks 🎉