Fix navigation jumpiness on theme toggle click

not-matthias / apollo

Modern and minimalistic blog theme.

https://not-matthias.github.io/apollo

MIT License

121 stars 70 forks source link

Fix navigation jumpiness on theme toggle click #31

Closed peterkos closed 11 months ago

peterkos commented 11 months ago

Background

Hello! I noticed a bit of jumpiness toggling between light/dark mode, and saw that some of the HTML could be cleaned up too.

Follows up on #26

Changes

href="" -> href="#", no reload
Moved inline CSS to header.sass for #hygeine :)

Preview

Before	After

not-matthias commented 11 months ago

That's quite smart with the href="#", didn't think of that. Thanks for the PR! :)

peterkos commented 11 months ago

Thanks!

Ah, noticed this after pushing updates to my blog: it'll put the # in the URL 😅 -- one alternative is to do href="javascript:void(0)" [src], would be a bit cleaner

not-matthias commented 11 months ago

Fixed!