search

not-nexus / shelf

REST API for AWS S3 meant to be an interface to immutable artifact storage.
MIT License
8 stars 3 forks source link

Casting the value of a version sort to a string. #106

Closed GoogilyBoogily closed 7 years ago

GoogilyBoogily commented 7 years ago

Also added a test for making sure that if a version number was an int, the sorter won't break.

codecov-io commented 7 years ago

Codecov Report

Merging #106 into develop will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #106   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           74     74           
  Lines         2013   2014    +1     
======================================
+ Hits          2013   2014    +1
Impacted Files Coverage Δ
shelf/search/sorter.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3e96133...f5bd85d. Read the comment docs.

kyle-long commented 7 years ago

Also it looks like code coverage dropped