search

not-nexus / shelf

REST API for AWS S3 meant to be an interface to immutable artifact storage.
MIT License
8 stars 3 forks source link

Elasticsearch Connection Retries #64

Closed quantumew closed 8 years ago

quantumew commented 8 years ago

We should look into Elasticsearch connection retry functionality. What spurred this was a build that failed randomly because we couldn't connect to the Elasticsearch setup on the Travis CI instance. This was a "fluke" error with an unknown cause. We retried the build and it passed. Perhaps this could be avoided or chance of it happening greatly reduced by connection retries. I would expect this to be configurable.

quantumew commented 8 years ago

Travis CI notifications added and it appears Elasticsearch-py connection layer automatically retries connection 3 times. Testing this it appears this is not working properly. Will look into this further.

quantumew commented 8 years ago

This was fixed by @kyle-long. See https://github.com/kyle-long/pyshelf/pull/75.