search

not-nexus / shelf

REST API for AWS S3 meant to be an interface to immutable artifact storage.
MIT License
8 stars 3 forks source link

Implementing hooks #97

Closed kyle-long closed 7 years ago

kyle-long commented 7 years ago

I took many shortcuts in preperation for the rewrite we think will be coming.

codecov-io commented 7 years ago

Codecov Report

Merging #97 into develop will not impact coverage.

@@           Coverage Diff           @@
##           develop    #97    +/-   ##
=======================================
  Coverage      100%   100%            
=======================================
  Files           63     72     +9     
  Lines         1837   1985   +148     
=======================================
+ Hits          1837   1985   +148
Impacted Files Coverage Δ
shelf/artifact_manager.py 100% <100%> (ø) :white_check_mark:
shelf/hook/container.py 100% <100%> (ø)
shelf/hook/background/container.py 100% <100%> (ø)
shelf/hook/manager.py 100% <100%> (ø)
shelf/metadata/container.py 100% <100%> (ø) :white_check_mark:
shelf/metadata/manager.py 100% <100%> (ø) :white_check_mark:
shelf/hook/event.py 100% <100%> (ø)
shelf/hook/null_manager.py 100% <100%> (ø)
shelf/hook/background/command_runner.py 100% <100%> (ø)
shelf/utils.py 100% <100%> (ø) :white_check_mark:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c29d2c0...ac39955. Read the comment docs.

kyle-long commented 7 years ago

Actually I already found a problem. It appears it is identifying the scheme as "http" instead of "https" for some reason when using https.

Need to look into why this might be the case

Update: You can disregard this comment. I forgot our test environment is doing ssl termination.

kyle-long commented 7 years ago

ac39955869131e263aff9d20714c208b0ec4d591

Code review fixes