Open LaurentFough opened 1 year ago
Thanks for the contribution, I never worked with homebrew before
Thanks for the contribution, I never worked with homebrew before
- Shouldn't the homebrew file reference the dependencies (curl, jq)?
- I feel like it should try to add the lines to .zshrc automatically (and remove them upon uninstall), and only list caveat about OpenAI key. Some users might even have the API key in their environment as the number of different AI tools grows rapidly. Although in this case we probably should suppress the API key warning on startup.
- What this regex does?
- Even the smallest improvements are welcome!
@not-poma Great feedback, thanks for taking a look.
depends_on
for curl
& jq
.build-status
references from the README.md, if you go that route.$XDG_CONFIG_HOME/lazyshell/config
file; and reading in the API_KEY, and keybindings from it, etc.I also have a clean method of using wget
for the API call; then failing over to curl
if needed.
- we definitely don't want to be in a situation where we make changes to a users shell init, those changes get edited and during uninstall we can't uninstall correctly as we don't know what to look for.
imho: Asking, then adding as [[ -r $pathto/lazyshell.zsh ]] && ...
is reasonable.
I also have a clean method of using wget for the API call; then failing over to curl if needed.
Forgot to mention that I've implemented this fallback after you mentioned it.
imho: Asking, then adding as [[ -r $pathto/lazyshell.zsh ]] && ... is reasonable.
brew installs are usually non-interactive, not sure where would be a good place to ask this.
Hey;
Very interesting project. Been using/testing it for a a couple of days; and started picking off items on the roadmap.
I've created a working Homebrew formula (+makefile), plus a Github Actions release file, to generate shasums, for releases.
You can test it first, then I can create a proper PR.
Repo here: https://github.com/LaurentFough/lazyshell
** There are some other small code tweaks that I can push; as well.