Get latest WSL kernel version for windows-install.sh

y2k04 commented 2 months ago

Removed qemu-kvm cause that is deprecated
Added comments
Added more progress bars

Summary by Sourcery

Update the windows-install.sh script to automatically fetch the latest WSL kernel version, enhance user feedback with progress bars, and improve script readability with comments and quieter command outputs.

New Features:

Automatically fetch the latest WSL kernel version from the GitHub API for installation.

Enhancements:

Add progress bars to the script using 'pv' for better user feedback during the extraction process.
Improve script output by adding comments and using quieter options for package management commands.

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request updates the Windows installation script for WSL (Windows Subsystem for Linux) to automatically fetch and use the latest WSL kernel version. It also improves the installation process by adding more informative comments, progress indicators, and removing deprecated packages.

File-Level Changes

Files	Changes
`windows-install.sh`	Updated package installation command to use quiet mode and removed the deprecated qemu-kvm package
`windows-install.sh`	Added a script to fetch the latest WSL kernel version from GitHub API
`windows-install.sh`	Replaced hardcoded kernel version with dynamically fetched latest version
`windows-install.sh`	Added progress indicators for download and extraction processes
`windows-install.sh`	Added comments to improve script readability and maintainability

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

notAperson535 commented 2 months ago

@y2k04 Thanks for the PR! Just a question, I can't seem to figure out what the -q argument in the apt command is doing. Could you please let me know?

y2k04 commented 2 months ago

-q is for quiet mode. the more q's, the less info. It just makes it less spammy.

notAperson535 commented 2 months ago

@y2k04 Gotcha. I'll test it on my machine and if it works it'll be merged

notAperson535 commented 2 months ago

Merging now, thanks!

ArsenicBismuth commented 2 months ago

Are the angle brackets here intentional? I seem to got issue with them: https://github.com/notAperson535/OneClick-macOS-Simple-KVM/issues/115

The ones with angle brackets seem to miss some stuff, like in line 25.

notAperson535 / OneClick-macOS-Simple-KVM