search

notAperson535 / OneClick-macOS-Simple-KVM

Tools to set up a easy, quick macOS VM in QEMU, accelerated by KVM. Works on Linux AND Windows.
https://notAperson535.github.io/OneClick-macOS-Simple-KVM
MIT License
661 stars 52 forks source link

Trying to fix `windows-install.sh` to fix #115 #116

Closed ArsenicBismuth closed 3 months ago

ArsenicBismuth commented 3 months ago

Was trying it out today, but got some line error issues. Turns out windows-install.sh is from a recent PR #113.

Detailed my issue in #115. Basically some lines seem to be replaced by > angle bracket? Possibly merging issue? But then @notAperson535 confirmed the PR to be working on his side.

So all in all, I was unsure why the original PR included that, but here's a version that worked perfectly on my side.

Also fixed the fallback for tagging, since for example: https://github.com/microsoft/WSL2-Linux-Kernel/releases/tag/5.10.102.1 is invalid. If successful, latest produce the full tag: linux-msft-wsl-5.10.102.1, so the fallback should follow the same format.

Sorry if I'm wrong.

Summary by Sourcery

Fix errors in windows-install.sh by removing an incorrect angle bracket in the package installation command and updating the fallback version tag format to ensure compatibility with the expected kernel versioning.

Bug Fixes:

sourcery-ai[bot] commented 3 months ago

Reviewer's Guide by Sourcery

This pull request addresses issues with the windows-install.sh script, specifically fixing line errors and improving the fallback mechanism for kernel version tagging. The changes focus on correcting command syntax and adjusting the version string format to ensure compatibility with GitHub release tags.

File-Level Changes

Files Changes
windows-install.sh Fixed a truncated apt install command by removing the angle bracket at the end of the line
windows-install.sh Updated the fallback kernel version string to include the full tag format
windows-install.sh Corrected the aria2c download command by removing the trailing angle bracket and using the full version string in the URL
Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
notAperson535 commented 3 months ago

@ArsenicBismuth It worked for me because I already had previous dependencies installed, so it still worked even with the messed up angle bracket. Thanks for catching this so quick, I’ll merge it now

ArsenicBismuth commented 3 months ago

@notAperson535 I actually found and tried your script just today, so I didn't even know it's caused by a recent PR. Good to know it's working!