search

notDmDrl / pull_down_button

A package that implements Pull-Down Button from iOS 14 in Flutter. Highly customizable.
https://pub.dev/packages/pull_down_button
MIT License
76 stars 25 forks source link

Can leading widget for PullDownMenuHeader be further customized? #50

Open mark8044 opened 3 weeks ago

mark8044 commented 3 weeks ago

First, phenomenal work on this. Its quite slick package.

The leading widget right now will always put your items in a grey box in iOS style. But in the future, iOS style may change, so we should have the ability to customize that leading widget. For example, no grey box with drop shadow, etc...

Or at the very least make the leading widget optional so we are not forced to put something there

notDmDrl commented 2 weeks ago

Hi @mark8044,

But in the future, iOS style may change, so we should have the ability to customize that leading widget.

Yes, this might be a problem in the future as I no longer actively maintain this package since I don't have access to any Apple products anymore so I can't even verify if UI-related stuff is correct since most in-depth design docs they provide are in Sketch which is MacOS exclusive app 😞

This is a valid request and I'll try to come up with some update for this soon

Or at the very least make the leading widget optional so we are not forced to put something there

Wouldn't making the leading widget optional be redundant? You might as well use the normal PullDownMenuItem, no? But I guess that might also be nice to have

mark8044 commented 2 weeks ago

Hi @mark8044,

But in the future, iOS style may change, so we should have the ability to customize that leading widget.

Yes, this might be a problem in the future as I no longer actively maintain this package since I don't have access to any Apple products anymore so I can't even verify if UI-related stuff is correct since most in-depth design docs they provide are in Sketch which is MacOS exclusive app 😞

This is a valid request and I'll try to come up with some update for this soon

Or at the very least make the leading widget optional so we are not forced to put something there

Wouldn't making the leading widget optional be redundant? You might as well use the normal PullDownMenuItem, no? But I guess that might also be nice to have

You know of course you are right! Im an idiot. I did not realized that PullDownMenuItem still gave you the options of the subtitle and icon, so yes that is a better implementation for my use case.

I still like the idea of being able to update the icon on the left, but this is now very low priority :)

Thanks so much!