Diacritics not matched in search in Create and Search dialogs

notaapp / talk

Issues and discussions for the notes app, Nota.

https://nota.md

59 stars 1 forks source link

Diacritics not matched in search in Create and Search dialogs #331

Closed petrbouchal closed 1 year ago

petrbouchal commented 1 year ago

In my root folder, I have md files whose file names contain the following strings:

RMŽ
účel
and lots of other files whose names do not contain these strings

Here is what I observe when I enter the strings below into the Search or Create field:

when I type "účel", nothing matches
when I type "ucel", nothing matches
when I type "RMZ" or "rmz", the file with "RMŽ" in its name matches and some others based where the words start with r amd m etc.
when I type "RMŽ" or "RMŽ", nothing matches from the moment I hit the Ž/ž key

Possibly related #303, in which case this issue will be irrelevant.

astoilkov commented 1 year ago

Sorry for the late response. Yeah, this is a bug. I will try to fix it for the next release.

astoilkov commented 1 year ago

This couldn't be fixed without implementing full support for diacritics. In the next release, typing "ucel" will find "účel".

petrbouchal commented 1 year ago

I feel like this was fixed in 0.39 (there's a related-sounding point in the changelog) but regressed in 0.40 - just flagging in case I remember this correctly, but it may well be that there was in fact no change in 0.39 with respect to the Create/Search dialogs.

astoilkov commented 1 year ago

Oops. You are right. I actually broke it recently just before both releases. I now fixed it. The next release will include it. Sorry.

astoilkov commented 1 year ago

This is now part of the latest release. Closing this issue.

Thanks for the feedback!