search

notablemind / jupyter-nodejs

A node.js kernel for jupyter/ipython
http://nbviewer.ipython.org/gist/jaredly/404a36306fdee6a1737a
MIT License
682 stars 70 forks source link

No longer builds due to a problem in the contextify dependency #40

Closed ResidentMario closed 7 years ago

ResidentMario commented 7 years ago

See this issue: https://github.com/brianmcd/contextify/issues/212.

Since contextify is deprecated, how hard would it be to move this over to its replacement Node-native vm module?

ResidentMario commented 7 years ago

Slightly more information: the error occurs at npm install && node install.js, and the text is:

npm ERR! contextify@0.1.15 install: `node-gyp rebuild`
npm ERR! Exit status 1
jsnelgro commented 7 years ago

has anybody come up with a workaround for the time being?

jaredly commented 7 years ago

I just dropped the contextify dep, and moved over to the vm module. The only downside is that vm doesn't give us access to the global object, so completions on built-in variables are a bit more limited. but other than that, we're all set! install jupyter-nodejs@2.0.0 and let me know how it goes!

jsnelgro commented 7 years ago

@jaredly up and running! Awesome!