search

notablemind / jupyter-nodejs

A node.js kernel for jupyter/ipython
http://nbviewer.ipython.org/gist/jaredly/404a36306fdee6a1737a
MIT License
682 stars 70 forks source link

Fix up devDependencies #63

Closed thomasjm closed 6 years ago

thomasjm commented 6 years ago

The dependencies and devDependencies were a little scrambled. This PR fixes them up so that it's easier to do things like npm prune --production to save space.

jaredly commented 6 years ago

Babel is a dependency though https://github.com/notablemind/jupyter-nodejs/blob/1388e1957792ef167ccfc7a9cf6c64c3950ded76/config.js

thomasjm commented 6 years ago

Oh, whoops. Is babel-runtime needed as well? I don't see it imported explicitly anywhere.

The reason I bring it up is because the two of them are quite heavy dependencies, costing 30MB or so. I've been trying to make a reasonably small Docker image with Jupyter kernels on it and would love to trim it down. Maybe it would be possible to install Babel on the fly, or even split it into a separate kernel? Would appreciate your thoughts on this.

Anyway I'll close this PR.

jaredly commented 6 years ago

I think babel-runtime was a peer-dependency of babel? can't remember at the moment. tbh, I'd be fine removing the babel syntax extension, or making it opt-in, because lots of the things that it was doing back when I wrote this kernel have been adopted by all the major browsers.