notadamking / RLTrader

A cryptocurrency trading environment using deep reinforcement learning and OpenAI's gym
https://discord.gg/ZZ7BGWh
GNU General Public License v3.0
1.71k stars 537 forks source link

[Suggestion] - Feed data from multiple exchanges #60

Closed uBadRequest closed 5 years ago

uBadRequest commented 5 years ago

I believe if you feed the data from multiple exchanges into the model, it will learn to predict price movements better, based on patterns it has found in how the price change affects the other exchanges.

mprestonise commented 5 years ago

@uBadRequest Can you elaborate on this? How would this improve the model?

uBadRequest commented 5 years ago

@uBadRequest Can you elaborate on this? How would this improve the model?

Think about what we're trying to do here, predict the price of bitcoin and make a profit. If the model can learn based off of the trading activity occurring at the same time across multiple exchanges, i'd expect a better outcome. An example might be someone dumping bitcoin on other exchanges, such as bitfinex for example, causing price fluctuation unseen on other exchanges. That exchange may have more of an influence on the actual price of bitcoin than say just what was happening on coinbase. Even during live trading, if the bot can be fed hourly price updates across all exchanges, it will discover trends unseen to the human eye. Basically predicting the future price of bitcoin based on watching activity occuring across multiple exchanges. I'm really interested to see live trading results, as i'm currently trying to implement this ... @notadamking care to shed some wisdom?

robinvanleeuwen commented 5 years ago

What are the hyper-parameters you are using for the testing of data? Still the ones based on the #28 bug of the sorted date?

notadamking commented 5 years ago

Hi @uBadRequest, this is a great suggestion, and something similar has actually already been suggested in #3. I am going to close this issue in favor of keeping the conversation in one thread.