search

notadamking / Stock-Trading-Visualization

A simple, yet elegant visualization of our stock trading RL agent environment.
MIT License
212 stars 110 forks source link

Numpy put method being correctly used? #1

Closed Draichi closed 5 years ago

Draichi commented 5 years ago

Nice project mate,

After making some tests i'm having a problem, I think you are updating only the first and the 3th values on line https://github.com/notadamking/Stock-Trading-Visualization/blob/39ed1d4dc4ce734853f76a3256ed6de5ee963192/env/StockTradingEnv.py#L58 Is that right? here is the documentation https://docs.scipy.org/doc/numpy/reference/generated/numpy.put.html

I'm trying to understand what's happening here, i'm looking forward for you answer, thanks

notadamking commented 5 years ago

Ah, looks like you are correct. It should instead be np.put(frame, [0,1,2,3,4], [....

notadamking commented 5 years ago

I have updated the repo, thanks for the catch!