search

notahat / midi_patchbay

Hook up MIDI software and hardware and pass MIDI data between them, applying assorted filters on the way.
228 stars 54 forks source link

BUG: dark icon background in title bar #11

Open reznet opened 4 years ago

reznet commented 4 years ago

The Midi Patchbay file icon in a document window titlebar has a black background instead of being transparent. I don't think this happened in Mojave using version 1.0.3

Version: 1.0.4 (2) OS: Catalina 10.15.2

Screen Shot 2019-12-20 at 8 20 30 PM

reznet commented 4 years ago

I don't know much about how macOS works with icons, but I thought I'd try to investigate. It looks like the problem is with the DocIcons.icns file. It appears to contain a copy of the icon at different resolutions. The high resolution images look have the correct background, but there are some low resolution images that have the black background (images 6 and 7 when you open the file in Preview - and images 4 and 5 appear to be missing or blank). Should these be updated to not have the black background? or are these supposed to be used for Dark Mode?

Screen Shot 2019-12-20 at 9 05 10 PM