Closed notahat closed 4 years ago
I agree to all, however I'd still recommend moving to ARC. The CoreMIDI stuff could use a second glance but everything else is simply removing retain/release and [super dealloc]
. There may be a few places where a manual release by setting to nil is warranted.
I've gone back to the drawing board on #2 and #4, because I wasn't comfortable with the memory management changes from #2. At best they'll leak memory, and I suspect they'll cause crashes in edge cases.
I also spotted some changes that, while they fixed warnings, left holes in the associated functionality.
So I've gone back to master, and started fixing and pulling in changes bit by bit. Specifically, I:
There are still lots of deprecation warnings, some of which simply need code pulled across from #4, and some of which are trickier.
In particular:
Other things still do to:
Things to test:
Other puzzles:
/cc @danomatika