search

notandy / ympd

Standalone MPD Web GUI written in C, utilizing Websockets and Bootstrap/JS
http://www.ympd.org
GNU General Public License v2.0
517 stars 144 forks source link

Make dirble API token configurable and use HTTPS #140

Closed lesderid closed 6 years ago

lesderid commented 8 years ago

The API key for Dirble should be configurable, so people can use their own account and the limit isn't reached.

It should also use HTTPS, so if ympd is behind a TLS proxy, the browser won't refuse to load it.

tatoosh commented 6 years ago

Any news here for implementation the Dirble API option?

lesderid commented 6 years ago

@tatoosh Still waiting on the Dirble dev to enable CORS afaik.

tatoosh commented 6 years ago

@lesderid thx. i looked in the sources - can we enable 'Access-Control-Allow-Origin' in mongoose.h ?

lesderid commented 6 years ago

@tatoosh No, it's a change the Dirble dev needs to make on their side, we can't really do anything about it (unless we proxy the API requests, but that might take a bit of work to implement).

tatoosh commented 6 years ago

Ok. Should we implement other services like shoutcast?

lesderid commented 6 years ago

@tatoosh I'm not sure what you're asking. I suggest opening a separate issue for this.