notandy / ympd

Standalone MPD Web GUI written in C, utilizing Websockets and Bootstrap/JS
http://www.ympd.org
GNU General Public License v2.0
523 stars 144 forks source link

songs not listed #27

Closed sedrubal closed 8 years ago

sedrubal commented 10 years ago

I detected, that some songs are not listet in the database-view of ympd, but the database of mpd contains them, because ncmpc lists them. Unfortunately I did't see something special on this songs...

ghost commented 10 years ago

I have the exact same problem with various flacs albums of my collection. When I browse the database, I click on an album directory and it shows empty. If I click add the whole directory it's ok and the songs appear in queue. In addition I can normally see the files in directories using MPdroid or other clients.

Please feel free to ask me for anything additional that will help you debug.

notandy commented 10 years ago

Could you send me some information about the filenames and tags of the affected files? I couldn't reproduce it yet

sedrubal commented 10 years ago

ok. For example there is a folder called "Hardwell". It contains 138 songs. One song is like this:

Artist:  HARDWELL
Titel:     Adrian Lux ft. Rebecca & Fiona - Boy (Hardwell Remix)
Length:     2:23
Genre:     Progressive House
Path:       Hardwell/Adrian Lux ft. Rebecca & Fiona - Boy (Hardwell Remix).mp3
MPD Statistic
Artist Count:      630
Album Count:         853
Songs Count:        9887
ghost commented 10 years ago

Hi,

the latest issue was with the following:

file name : 01 Brando.flac directory: Scott Walker + Sunn O))) - Soused [2014] CD FLAC tags: http://s17.postimg.org/zefkkht73/bug_1.jpg

yjokawa commented 9 years ago

Hi,

First of all, thank you for this great mpd client!

I also have the same trouble. When I first build ympd in March, the binary works completely. However, when I build it in August, the bug appeared. I suppose that mongoose 5.6 causes this problem, but I don't have any direct evidence.

Regards, yjo

yjokawa commented 9 years ago

When returning no song info, mpd gives the following error: MPD mpd_send_list_meta: Not found MPD connection failed.

tedigh commented 8 years ago

Hi, In my case, the folders / songs those contain "comma" in their names are missing. I find the calls of strtok() in mpd_client.c do wrong with them. The removal of 4ba3e0b70ffa0f47d99a13d7758e613628c4a607 seems to be one of the solutions.

LordMyschkin commented 8 years ago

thats exactly the same bug I filed under issue #106. Commas may be part of the problem, but I also do not see a file named "01_-_johannesbrahms-_klavierkonzert_nr._1-_maestoso.mp3" If you want to reproduce the problem, I send you the link to my library - or some of my files... Please let me know if I can be of any help - or point me to the best IDE to debug ympd on the raspberry....

tedigh commented 8 years ago

I found at least some special characters in the directory names cause this issue. try the both. sed -i 's/codeURI/codeURIComponent/g' htdocs/js/mpd.js revert 4ba3e0b (merge conflict needs to be resolved by hand)

SuperBFG7 commented 8 years ago

I just ran into this as well and created a fix: #116 it's already included in my fork

LordMyschkin commented 8 years ago

Thank you so much, @SuperBFG7; it works finally!

SuperBFG7 commented 8 years ago

You're welcome. Thanks @tedigh for pointing me in the right direction.

yjokawa commented 8 years ago

Thank you, SuperBFG7! I also succeeded. Your fix works very well!!

notandy commented 8 years ago

should be fixed now