search

notandy / ympd

Standalone MPD Web GUI written in C, utilizing Websockets and Bootstrap/JS
http://www.ympd.org
GNU General Public License v2.0
523 stars 144 forks source link

always display artist, album, track number #28

Open robotanarchy opened 10 years ago

robotanarchy commented 10 years ago

Hello,

when you have a huge music collection and search for one song, it is very hard to tell, from which band it is (cover songs or original?), or if it is a live/acoustic/instrumental version etc.

So could you please add the artist, album and track number to both the playlist view and the search results?

In case you fear that this will take up too much space, you could group albums in a cool way like (among lots of other players) cantata does:

2014-09-02-214957_1366x768_scrot

Thanks for creating this lightweight webinterface!

laclaro commented 10 years ago

A huge plug for this!

laclaro commented 10 years ago

I figured that you have to add these things to the C-source to be able to display this information in the web frontend as they are not yet requested by ympd. But in this case I end up with an unstable ympd which crashes on accessing the playlist if there are more than a couple of songs in the queue. Maybe the JS-object gets too large. I hope that I'll be able to dig a bit further soon.

http://s14.directupload.net/images/141110/mkzm24ux.png

robotanarchy commented 10 years ago

Cool, that you are working on this laclaro! :+1:

laclaro commented 10 years ago

I got it. The instability was caused by the direct use of some tag-fetching function. This left the value undefined whenever the tag was not present (->crash).

It would be favorable to be able to choose which tags to display as columns. This would require us to pull every tag field within mpd_client.c to be able to add columns flexible in JS.

For now, you have to recompile if you wish to have another column order, or more or less columns. You should be able to learn from the patch file where you would have to change things.

For browse-view in mpd.js: make sure you always have the same number of html-columns for playlist, song and dir types (by adding or removing empty ones in dir and playlist).

I created a pull request. Check it out here: https://github.com/notandy/ympd/pull/43

best regards Henning

robotanarchy commented 10 years ago

very nice :+1: :+1: :+1: lets see what @notandy says to this :)

nebbishOne commented 9 years ago

+1 from me. Thanks for considering this idea.

robotanarchy commented 9 years ago

@nebbishOne: Well, the last reply to this thread was more than a year ago. So I think it is not likely that anyone is working on this feature anymore. If you really want it, you could try to hack it in yourself and do a pull request :)

SuperBFG7 commented 9 years ago

@nebbishOne: Have a look at my fork, I included the proposed pull request.

Blum commented 8 years ago

:+1: This is a must-have for me. Great job folks!