various patches: manpage, remove external js, init scripts

notandy / ympd

Standalone MPD Web GUI written in C, utilizing Websockets and Bootstrap/JS

http://www.ympd.org

GNU General Public License v2.0

523 stars 144 forks source link

various patches: manpage, remove external js, init scripts #72

Closed jpleau closed 9 years ago

jpleau commented 9 years ago

Hi !

As discussed by email. I split each patch in a separate commit.

I was also wondering if it would make sense to install the init script, systemd unit file as well as the new ympd.default file I've added, with cmake.

Basically: If we can detect systemd is installed, install the .service, if not, install the init script. Always install the default config file (ympd.default -> /etc/default/ympd)

What do you think ?

notandy commented 9 years ago

An earlier version of the cmake file did indeed install the init script, but there are several objections against it:

It's quite hard to detect the current init system, there are so many out there - impossible to consider all of them.
init detection would massively bloat the cmakelists.txt (okay, could be exported to an external file, but still it makes hard to debug)
I think that's the job of the package maintainer to select the right init-script when building the final package.

So I am satisfied with the current state :)