search

notanumber / xapian-haystack

A Xapian backend for Haystack
GNU General Public License v2.0
154 stars 93 forks source link

Github Actions - coveralls integration needs more work #205

Closed asedeno closed 3 years ago

asedeno commented 3 years ago

How xapian-haystack's tests get run confuses coveralls, and causes links to the repo / commit to not work.

Essentially, because the test process copies pieces of xapian-haystack into a checkout of django-haystack, coveralls detects the commit id from django-haystack.

Because file paths across the projects not not match, just ensuring that coveralls gets the right commit id will not fix all of the issues here.

I don't have a solution to this issue in mind yet.

Tangentially related to this, coverage does not appear to detect that xapian_backend.py was used when running tests, so we don't have coverage data on that.

claudep commented 3 years ago

I would not be so shocked if we simply drop coverage report. In any case, any new/changed feature must come with tests, so...

asedeno commented 3 years ago

Coverage is good, and this was bothering me. Nothing motivates me like something bugging me. 😄

claudep commented 3 years ago

You are awesome :smile: