search

notanumber / xapian-haystack

A Xapian backend for Haystack
GNU General Public License v2.0
154 stars 93 forks source link

Better coverage handling #206

Closed asedeno closed 3 years ago

asedeno commented 3 years ago

Use coverage combine with some more configuration in .coveragerc to merge our own paths with the paths we copy to when running coverage and tests in the django-haystack checkout.

Also, print the simple coverage report in the Github Actions workflow for good measure.

Fixes: #205

asedeno commented 3 years ago

Also, sorry, not sorry, this will drop the coverage rating a smidge since it's now picking up test coverage of xapian_backend.py. 😄

claudep commented 3 years ago

Looks like the tests files are included in the coverage. Shouldn't they be excluded?

asedeno commented 3 years ago

They've always been included in the coverage, so I didn't see fit to remove them.

asedeno commented 3 years ago

Having given this some more thought, no, they should be left in. It shows that they are being run.

claudep commented 3 years ago

I don't want to fight on this. You did the job, so you decide, even if my personal opinion didn't change :-)