search

notanumber / xapian-haystack

A Xapian backend for Haystack
GNU General Public License v2.0
154 stars 93 forks source link

Move stemming and weighting scheme into connection_options? #99

Open SimonSteinberger opened 12 years ago

SimonSteinberger commented 12 years ago

Does it make sense, to move HAYSTACK_XAPIAN_LANGUAGE and HAYSTACK_XAPIAN_WEIGHTING_SCHEME into connection_options (settings.HAYSTACK_CONNECTIONS)?

I've modified the backend for a project, in order to switch stemming language with the index. Comes in handy for multi-language sites and somehow I believe it fits in there:

xapian_backend.py, LOC 154: self.language = connection_options.get('HAYSTACK_XAPIAN_LANGUAGE', 'english') self.weighting_scheme = connection_options.get('HAYSTACK_XAPIAN_WEIGHTING_SCHEME', None)

from django.config import settings may be removed in this case

jorgecarleitao commented 10 years ago

+1, however, this breaks backward compatibility, which means we would have to create a deprecation timeline.