search

notaryproject / notaryproject.dev

Notary Project Website
https://notaryproject.dev
Other
25 stars 57 forks source link

fixes #325 by updating references to The Notary Project #327

Closed zr-msft closed 11 months ago

zr-msft commented 1 year ago

fixes #325

netlify[bot] commented 1 year ago

Deploy Preview for notarydev ready!

Name Link
Latest commit a408a79a91a94c30c3d6bfa7a8d170a27111488f
Latest deploy log https://app.netlify.com/sites/notarydev/deploys/650099ee31349000080701a6
Deploy Preview https://deploy-preview-327--notarydev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zr-msft commented 1 year ago

@yizha1 and @FeynmanZhou the scope of this PR is specifically #325 which asks to update "Notary" to "The Notary Project" in the specified list of docs. I'll incorporate the targeted feedback, but the following are out of scope for this PR and should be handled in a different PR:

yizha1 commented 1 year ago

@yizha1 and @FeynmanZhou the scope of this PR is specifically #325 which asks to update "Notary" to "The Notary Project" in the specified list of docs. I'll incorporate the targeted feedback, but the following are out of scope for this PR and should be handled in a different PR:

Thanks @zr-msft. I am OK to create a new PR to update Project Overview.

FeynmanZhou commented 1 year ago

@yizha1 and @FeynmanZhou the scope of this PR is specifically #325 which asks to update "Notary" to "The Notary Project" in the specified list of docs. I'll incorporate the targeted feedback, but the following are out of scope for this PR and should be handled in a different PR:

@zr-msft Make sense. Feel free to raise a follow-up PR to update the project overview. We could merge this one after all comments above are resolved.

Thanks!

zr-msft commented 1 year ago

@yizha1 @FeynmanZhou @iamsamirzon incorporated/addressed your feedback

zr-msft commented 1 year ago

@yizha1 @FeynmanZhou @iamsamirzon please review when you have a chance

zr-msft commented 1 year ago

thanks @yizha1, incorporated your feedback

yizha1 commented 1 year ago

@iamsamirzon Would you mind re-reviewing this PR? Only the version number was changed to v1.0.0 since your last approval. Thanks.

zr-msft commented 12 months ago

@yizha1 @iamsamirzon fixed and rebased. PTAL