notaryproject / notaryproject.dev

Notary Project Website
https://notaryproject.dev
Other
23 stars 58 forks source link

chore: add GitHub action for stale issues and PRs #362

Closed yizha1 closed 8 months ago

yizha1 commented 8 months ago

This PR enables the notaryproject.dev repo to run stale action at 1:30 every day to label or close stale PRs and issues. See guideline https://github.com/marketplace/actions/close-stale-issues

This is the definition for stale PRs or issues that we discussed during community call and to be updated in contributing PR.

"A stale issue is one that remains inactive or without updates for a period of 60 days. A stale pull request (PR) is one that remains inactive or without updates for a period of 45 days. When an issue or PR becomes stale, it is labelled as stale. Normally maintainers will comment on stale issues or PRs to prompt participants to take action. If there is no activity for additional 30 days, this issue or PR will be closed. If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart"

netlify[bot] commented 8 months ago

Deploy Preview for notarydev ready!

Name Link
Latest commit b542c731b99ca1b3de663c7ba75e70115b7b764b
Latest deploy log https://app.netlify.com/sites/notarydev/deploys/65431b411d13da000881068a
Deploy Preview https://deploy-preview-362--notarydev.netlify.app/blog/2023/notary-enlightning-podcast
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yizha1 commented 8 months ago

@zr-msft @iamsamirzon @FeynmanZhou @priteshbandi Please take a look at this PR, we can start practicing closing stale PRs or issues from notaryproject.dev repo firstly, then roll out to other repositories.

zr-msft commented 8 months ago

@yizha1 I like the idea of implementing this, but is there any way to delay closing if the PR is blocked waiting for a maintainer to respond or ACK?

I don't think its fair to automatically close a PR if a maintainer hasn't acted in a timely manner.

yizha1 commented 8 months ago

Thanks @zr-msft . You have a very good point. According to my knowledge, it seems there is no way to distinguish that the delay is due to inactive maintainers. This rule has a pre-condition that repo maintainers should be active. Do you have any suggestions? Maybe before we apply this rule, we first clean up the PRs manually. /cc @FeynmanZhou

FeynmanZhou commented 8 months ago

If an update/comment occur on stale issues or pull requests, the stale label will be removed, and the timer will restart"

@zr-msft @yizha1 I think this rule might be the effective way to delay closing if the PR is blocked waiting for a maintainer to respond. We can comment in that issue/PR to remind related maintainers, this will keep the PR/issue still in an active discussion status.

I admit that we definitely need to find a time to manually clean up some stale PRs and issues.

zr-msft commented 8 months ago

As long as we define a process to avoid this issue, i'm fine with merging