search

notaryproject / notation-action

GitHub Actions for signing and verifying artifacts with Notation
https://notaryproject.dev/
Apache License 2.0
16 stars 7 forks source link

update: refactored notation-action repo #14

Closed Two-Hearts closed 1 year ago

Two-Hearts commented 1 year ago

This PR refactors the repo. The refactored Github Actions are tested by this build.

Resolves #6, #10, #11, #12, and #13

Two-Hearts commented 1 year ago

I would like to see if we can refactor out dist, package-lock.json, packae.json, and tsconfig.json.

Good idea. Will do some reorganize on those files.

Two-Hearts commented 1 year ago

As suggested by @shizhMSFT, reorganized the repo following pattern of codeql. (Note: the node_modules folder is now required since it holds all the import dependencies of the project.)

Tested with this build.

Two-Hearts commented 1 year ago

@Two-Hearts This PR contains 3 changes:

  1. code refactoring
  2. add Apache 2.0 license
  3. support downloading using checksums

Could you split this PR into 3 PRs?

@shizhMSFT I removed license related file from this PR. Will create another one to add license later. However, for support checksums, this is one of the main purposes for the current PR. Because the logic is already in the sign action. I'm just pulling it out and relocating it in a common lib in this PR.