search

notaryproject / notation-action

GitHub Actions for signing and verifying artifacts with Notation
https://notaryproject.dev/
Apache License 2.0
16 stars 7 forks source link

Proposal: Reduce the required number of approvals to `1` #8

Closed shizhMSFT closed 1 year ago

shizhMSFT commented 1 year ago

It is currently not reasonable to have 2 approvals for merging a PR where we only have 3 repo-level maintainers and one of them is the PR author.

Therefore, I propose that we should reduce the required number of approvals before merging from 2 to 1 for the notation-action repo. Once we have more repo-level maintainers, we can revert the change.

yizha1 commented 1 year ago

LGTM

priteshbandi commented 1 year ago

LGTM

duffney commented 1 year ago

LGTM

toddysm commented 1 year ago

LGTM. I went ahead and modified the requirement to 1 approval