search

notaryproject / notation-core-go

Contains support for Notary Project signature envelope, and format specific implementation
Apache License 2.0
14 stars 28 forks source link

OCSP request missing logs #223

Closed JeyJeyGao closed 1 month ago

JeyJeyGao commented 2 months ago

What is not working as expected?

We have refactored the revocation interface to be 

// Validator is an interface that provides revocation checking with
// context
type Validator interface {
    // ValidateContext checks the revocation status given caller provided options
    // and returns an array of CertRevocationResults that contain the results
    // and any errors that are encountered during the process
    ValidateContext(ctx context.Context, validateContextOpts ValidateContextOptions) ([]*result.CertRevocationResult, error)
}

The OCSP package should use the ctx when sending the request to write the logs.

http.NewRequestWithContext(ctx, http.MethodGet, url, nil)

What did you expect to happen?

No

How can we reproduce it?

No

Describe your environment

Source code

What is the version of your notation-core-go Library?

v1.1.0-rc.1