search

notaryproject / notation-go

A collection of libraries for supporting sign and verify OCI artifacts. Based on Notary Project specifications.
Apache License 2.0
39 stars 42 forks source link

ci/cd: consider exporting some go routines so other projects can ci/cd against notation #22

Open rchincha opened 2 years ago

rchincha commented 2 years ago

For example,

https://github.com/notaryproject/notation/blob/main/cmd/notation/cert_gen.go

sajayantony commented 2 years ago

Should this issue be in https://github.com/notaryproject/notation-go-lib

rchincha commented 2 years ago

https://github.com/notaryproject/notation/pull/141 ^ here is a draft PR that could help. Would be even better if some routines can be pulled out without tying to cli context.

rchincha commented 2 years ago

Should this issue be in https://github.com/notaryproject/notation-go-lib

^ looks a little low-level for the use case in mind. I would have to re-implement signer and verifier perhaps.

SteveLasker commented 2 years ago

Hi @rchincha, Thanks for the PR and Issue. We're hoping to keep the CLI focused on core CLI scenarios, with minimal surface area. The functionality you need, should be enabled through the go-libraries. But, this does bring up an interesting point for how the notation plug-ins will work.
I'd like to transfer this to the notation-go-lib for tracking. I'll open an issue related to using plug-ins, when using the notation-go libraries.

yizha1 commented 3 days ago

@rchincha is this issue still valid? Currently Notary Project support Notation GitHub actions, which may also help you integration with CI/CD pipelines.