search

notaryproject / notation-go

A collection of libraries for supporting sign and verify OCI artifacts. Based on Notary Project specifications.
Apache License 2.0
39 stars 42 forks source link

build: bump image-spec to v1.1.0-rc.3 and oras-go to v2.1.0 #306

Closed shizhMSFT closed 1 year ago

shizhMSFT commented 1 year ago

Closes #305 Closes #307

codecov-commenter commented 1 year ago

Codecov Report

Merging #306 (affc103) into main (06d04cc) will not change coverage. The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files          23       23           
  Lines        2175     2175           
=======================================
  Hits         1618     1618           
  Misses        439      439           
  Partials      118      118
Impacted Files Coverage Δ
registry/repository.go 49.35% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sajayantony commented 1 year ago

Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning?

rchincha commented 1 year ago

Also, under "internal/" so external imports don't work yet.

FeynmanZhou commented 1 year ago

Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning?

Agree with @sajayantony. This change is also supposed to be considered in Notation CLI.

shizhMSFT commented 1 year ago

Should we remove the ability to create artifactManifest mediaType and only allow for read with a deprecation warning?

This is partially addressed by #308. We might need more discussions on the warning and it can be done in another PR.