search

notaryproject / notation-go

A collection of libraries for supporting sign and verify OCI artifacts. Based on Notary Project specifications.
Apache License 2.0
39 stars 42 forks source link

feat: support distinguished name state(S) #432

Closed JeyJeyGao closed 3 months ago

JeyJeyGao commented 3 months ago

Resolves #431 Signed-off-by: Junjie Gao junjiegao@microsoft.com

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.74%. Comparing base (09e32d7) to head (ef85fc1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #432 +/- ## ========================================== + Coverage 80.73% 80.74% +0.01% ========================================== Files 33 33 Lines 2455 2457 +2 ========================================== + Hits 1982 1984 +2 Misses 331 331 Partials 142 142 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JeyJeyGao commented 3 months ago

This PR only covers the parsing parts. It does not include the comparation between parsed values. For example, does ST=Shanghai equal S=Shanghai?

Yes, you are right. Updated.

JeyJeyGao commented 3 months ago

LGTM;

Please sign your commits

Re-signed. Thanks!