fix: dir no longer panics when HOME and XDG_CONFIG_HOME are not set

notaryproject / notation-go

A collection of libraries for supporting sign and verify OCI artifacts. Based on Notary Project specifications.

Apache License 2.0

39 stars 42 forks source link

fix: dir no longer panics when HOME and XDG_CONFIG_HOME are not set #449

Closed JasonTheDeveloper closed 2 months ago

JasonTheDeveloper commented 2 months ago

This PR addresses the issue #446

In this PR I:

I removed the init() function from dir/path
When userConfigDir() returns an error, instead of panic(err) I default to the current directory instead
Split loadUserPath() into two new functions used to setup and return the values for UserConfigDir and UserLibexecDir
Added additional unit tests for the two new functions and to test the default directory is used when HOME is set to ""

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.98%. Comparing base (115509e) to head (5f6bf77). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #449 +/- ## ========================================== + Coverage 80.86% 80.98% +0.11% ========================================== Files 33 33 Lines 2483 2487 +4 ========================================== + Hits 2008 2014 +6 + Misses 332 331 -1 + Partials 143 142 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JeyJeyGao commented 2 months ago

@JasonTheDeveloper

The base branch requires all commits to be signed

You need to fix it.

JasonTheDeveloper commented 2 months ago

@JasonTheDeveloper

The base branch requires all commits to be signed

You need to fix it.

@JeyJeyGao All my commits are signed though? DCO also passed the sign off checks. Not sure why GitHub is saying The base branch requires all commits to be signed.