search

notaryproject / notation-go

A collection of libraries for supporting sign and verify OCI artifacts. Based on Notary Project specifications.
Apache License 2.0
39 stars 42 forks source link

test: add fuzz test #459

Closed AdamKorcz closed 1 month ago

AdamKorcz commented 2 months ago

Adds a fuzz test from cncf-fuzzing: https://github.com/cncf/cncf-fuzzing/blob/main/projects/notary/fuzz_pkix_test.go

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.34%. Comparing base (84c2ec0) to head (da93344). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #459 +/- ## ======================================= Coverage 81.34% 81.34% ======================================= Files 34 34 Lines 2578 2578 ======================================= Hits 2097 2097 Misses 335 335 Partials 146 146 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yizha1 commented 2 months ago

@AdamKorcz You may need to merge the latest changes and sign-off the commit again.

AdamKorcz commented 1 month ago

@AdamKorcz You may need to merge the latest changes and sign-off the commit again.

done

Two-Hearts commented 1 month ago

Hi @AdamKorcz, same to the notation-core-go PR, you will need to use the -S flag in your git command to sign the commit (needs to be capital S). The -s or --signoff flags only signoff the commit but not signing it.

AdamKorcz commented 1 month ago

Have signed the commit.