Configurable KV/transit engines

notaryproject / notation-hashicorp-vault

HashiCorp Vault provider for Notation

https://notaryproject.dev/

Apache License 2.0

7 stars 8 forks source link

Configurable KV/transit engines #24

Closed tomaszkrzyzanowski closed 2 weeks ago

tomaszkrzyzanowski commented 1 month ago

Hey!

I wrote a little patch for support configurable engines mountpoints and keys in Vault

This code allows to:

set non-standard mountpoints/names for transit/kv engine
set different key name for transit key (as it's unable to be nested in transit, while kv allows it)

Naming is inconsistent yet, and not very well-thought, so I'm open for suggestions :)

cipherboy commented 1 month ago

@tomaszkrzyzanowski Looks like I've caused this one to conflict, sorry!

tomaszkrzyzanowski commented 1 month ago

@tomaszkrzyzanowski Looks like I've caused this one to conflict, sorry!

@cipherboy no worries ;) actually I found 2 extra things which would need to be fixed anyway, so at least it should work well and be documented now ;)

Currently, the plugin and helper should take any combination of engine/key names and kv part can support nested keys without issues :)

FeynmanZhou commented 3 weeks ago

@cipherboy Would you reviewing this PR again? Thanks

tomaszkrzyzanowski commented 2 weeks ago

@cipherboy Could you take a look? 😅

cipherboy commented 2 weeks ago

@tomaszkrzyzanowski Thanks for the poke, and sorry for the delay!

tomaszkrzyzanowski commented 1 week ago

@cipherboy np, we are all busy :) and thank you for the review and merge

I will possibly make the changes you mentioned later - I'm considering writing the tests, when I will find another free quant of time to do this :)

anyway, thanks again Tomasz