search

notaryproject / notation

A CLI tool to sign and verify artifacts
https://notaryproject.dev/
Apache License 2.0
351 stars 84 forks source link

refactor: update verifier #1002

Closed Two-Hearts closed 3 months ago

Two-Hearts commented 3 months ago

This PR updates the verifier to use NewVerifierWithOptions with httputil.NewClient as OCSPHTTPClient.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (ed77da1) to head (c112103). Report is 1 commits behind head on main.

Files Patch % Lines
cmd/notation/verify.go 82.60% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1002 +/- ## ========================================== + Coverage 71.92% 72.01% +0.09% ========================================== Files 46 46 Lines 2265 2287 +22 ========================================== + Hits 1629 1647 +18 - Misses 438 440 +2 - Partials 198 200 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JeyJeyGao commented 3 months ago

LGTM, but pending on dependencies.

rgnote commented 3 months ago

LGTM. Will approve once mod files are updated.