notaryproject / notation

A CLI tool to sign and verify artifacts
https://notaryproject.dev/
Apache License 2.0
351 stars 84 forks source link

bump: upgrade golang version to v1.23 #1019

Closed Two-Hearts closed 2 months ago

github-advanced-security[bot] commented 2 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.01%. Comparing base (b683029) to head (a3d5781). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1019 +/- ## ======================================= Coverage 72.01% 72.01% ======================================= Files 46 46 Lines 2287 2287 ======================================= Hits 1647 1647 Misses 440 440 Partials 200 200 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JeyJeyGao commented 2 months ago

what about building.md?

Building above binaries require golang with version >= 1.22.

Two-Hearts commented 2 months ago

what about building.md?

Building above binaries require golang with version >= 1.22.

This should be correct? >= 1.22 includes 1.23. @JeyJeyGao

shizhMSFT commented 2 months ago

what about building.md?

Building above binaries require golang with version >= 1.22.

Good catch. Since go.mod requires 1.23, we should update the building.md for 1.23. This is also for security purposes.