notaryproject / notation

A CLI tool to sign and verify artifacts
https://notaryproject.dev/
Apache License 2.0
306 stars 84 forks source link

feat: notation plugin uninstall command #832

Closed Two-Hearts closed 7 months ago

Two-Hearts commented 7 months ago

This PR is based on the spec PR: https://github.com/notaryproject/notation/pull/809

It adds the notation plugin uninstall command.

Tests: The e2e test cases are also included in this PR.

Note: This PR depends on the notation-go PR: https://github.com/notaryproject/notation-go/pull/363

Update: PR https://github.com/notaryproject/notation-go/pull/363 has been merged.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (acb9707) 64.05% compared to head (2741c85) 64.39%.

Files Patch % Lines
cmd/notation/plugin/uninstall.go 69.35% 13 Missing and 6 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #832 +/- ## ========================================== + Coverage 64.05% 64.39% +0.33% ========================================== Files 40 42 +2 Lines 2323 2390 +67 ========================================== + Hits 1488 1539 +51 - Misses 709 720 +11 - Partials 126 131 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.