notaryproject / notation

A CLI tool to sign and verify artifacts
https://notaryproject.dev/
Apache License 2.0
306 stars 84 forks source link

Fix of setHttpDebugLog function #851

Closed Two-Hearts closed 6 months ago

Two-Hearts commented 6 months ago

What is not working as expected?

Creating an issue to track these comments: https://github.com/notaryproject/notation/pull/827#discussion_r1430982227 https://github.com/notaryproject/notation/pull/827#discussion_r1430983979

What did you expect to happen?

Quote from @shizhMSFT: When authClient.Client is nil, http.DefaultClient.Transport is changed to http.DefaultTransport if it is nil. Later, http.DefaultClient.Transport is changed to NewTransport. That's a global change and should be avoided.

How can we reproduce it?

nil

Describe your environment

all environments

What is the version of your Notation CLI or Notation Library?

current main branch