search

notaryproject / notation

A CLI tool to sign and verify artifacts
https://notaryproject.dev/
Apache License 2.0
302 stars 84 forks source link

Could you add Arm 32 in official release artefacts? #943

Open lmussier opened 1 month ago

lmussier commented 1 month ago

Is your feature request related to a problem?

I would like to use notation on arm32 processors.

What solution do you propose?

I'd like to see arm in the official releases

What alternatives have you considered?

Build notation on my own

Any additional context?

No response

lmussier commented 1 month ago

More or less the same request as this one https://github.com/oras-project/oras/issues/364 :)

yizha1 commented 1 month ago

@lmussier Are you interested in contributing to fix this issue?

lmussier commented 1 month ago

Short answer, yes. I can make it compile (already done in fact) but I was not able to run tests, I'll give it a try and if tests are ok I can definitively provide a PR for that. But I'm affraid is tests are KO I don't have the competencies to make them pass.

yizha1 commented 1 month ago

I appreciate your interest @lmussier. You can start working on it and the Notation maintainers will assist you if you encounter any issues. Feel free to ask your questions here. /cc: @notaryproject/notaryproject-notation-maintainers

lmussier commented 3 weeks ago

Hi @yizha1, The easiest is done in #956 Unit tests (make test) are ok, but I encounter some weird issues with e2e tests, they won't pass on a the current master head. See e2e.log, before this run there were failed tests around the truststore.

yizha1 commented 3 weeks ago

@lmussier If your PR passes verification and merged, it should be fine. Your log indicated some throttling issues from Docker hub