Update the branch policies - Githubissues

notaryproject / roadmap

Roadmap for Notary Project

7 stars 6 forks source link

Update the branch policies #86

Closed toddysm closed 1 year ago

toddysm commented 1 year ago

After reviewing the branch policies for the repository, it seems that the main and release branches can benefit with more strict push and PR review policies. I would like to propose updating those as follows: Note: @SteveLasker added checkboxes to indicate the current status

Use the following rules for main branch:

[x] Require PR before merging
[x] Require 2 approvals
[x] Dismiss stale PR approvals when new commits are pushed
[x] Require review from Code Owners
[x] Require status checks to pass before merging
[ ] Require conversation resolution before merging
[x] Require signed commits
[x] Do not allow bypass the above settings

Please add your comments and proposals for additional changes to this issue.

yizha1 commented 1 year ago

LGTM but IANAM

iamsamirzon commented 1 year ago

LGTM but IANAM

SteveLasker commented 1 year ago

New main branch rules created, with the above checkboxes completed.

vaninrao10 commented 1 year ago

LGTM but IANAM

iamsamirzon commented 1 year ago

LGTM but IANAM

iamsamirzon commented 1 year ago

LGTM but IANAM

priteshbandi commented 1 year ago

LGTM but IANAM

yizha1 commented 1 year ago

@toddysm Can we close this issue as enough LGTMs?

toddysm commented 1 year ago

I have updated the branch policies for main branch in the repo. Closing the issue.